What you have repeated again is not ironclad in every state.
You are right. If you get a DUI (in some states a low felony) or committed a felony at a young age, you can be admitted to a law school and take the bar exam. If you pass, you must also pass a "character test". You narrative is for those that are not licensed lawyers, when they commit a felony.
A practicing attorney that commits a felony is a whole different story. Especially one that has not only taken an oath as a new attorney, but also as an FBI agent. I seriously doubt that any state bar would excuse the violation of not just the new attorney oath, but the FBI oath as well.
A deal with the prosecutor will not overrule the state bar from taking a license from an attorney. And consider the nature of the felony here. Clinesmith lied to the FISA Court, essentially perpetrating a fraud on the court. I doubt that there is a state bar in any state that would overlook that.
So, I am sticking with my original opinion. I guess we will find out in due time. But, I suspect that a deal with the prosecutor would entail loss of license in lieu of jail time.
HOPE IS MOTIVATION; REALITY IS PROFIT