Intel Corp (INTC)

[techno_bull]

A truly awful code error...

During peer review I always pushed back to the developer any code block that use explicit brackets around the code block even if it was a one-line block (like the goto fail; line).

So the code block should have been required to be:

if (err != 0)
{
goto fail;
}


And the coding error would look like this (but would NOT result in the 'fall through' error that caused the problem:

if (err != 0)
{
goto fail;
goto fail;
}