Note to all: Favorite Page
I just did a pretty substantial rewrite of the code for Favorites, which included streamlining it from 330 lines of code to 192, changing the way a lot of the processing is done, and optimizing the queries that drive it.
It *should* run quite a bit faster and, more importantly, since it's the second most frequently hit page on the site, should relieve the webserver of a noticeable amount of loading, helping everything to run faster.
Since this was an almost complete rewrite, look for bugs. I haven't found any yet, but that doesn't mean much.
Also, some of you have reported still seeing a pause (someone reported that it's as much as 2-3 seconds?!?) between the loading of the Boards list and the People list on that page.
Let me know if that pause has gone away. I didn't find anything that looked particularly like a culprit for that aside from some query/index tuning for both lists. Well, I take that back. I had the table names reversed in the INNER JOIN used for the People list, and for all I know, that might've been exactly what was causing the delay.
